Fix up references to full-screen modes - #20655
Conversation
There was a problem hiding this comment.
Pull request overview
Updates NVDA Magnifier terminology so user-facing strings (and related translator guidance) refer to “tracking mode” rather than “full-screen mode”, aligning with the current feature naming and reducing confusion for translators.
Changes:
- Updated a Magnifier settings translator comment to refer to “tracking mode”.
- Updated the Magnifier action description string to “change tracking mode”.
- Updated debug logging and the user announcement string to say “tracking mode”.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/gui/settingsDialogs.py | Updates translator comment for the “Tracking mode” setting label. |
| source/_magnifier/utils/types.py | Updates the localized action description to “change tracking mode”. |
| source/_magnifier/fullscreenMagnifier.py | Updates debug log terminology to “tracking mode”. |
| source/_magnifier/commands.py | Updates debug log + user announcement string and translator comment to “Tracking mode {mode}”. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SaschaCowley
left a comment
There was a problem hiding this comment.
nvda/source/_magnifier/config.py
Lines 241 to 243 in 9ca0a80
nvda/source/_magnifier/config.py
Lines 250 to 252 in 9ca0a80
There was a problem hiding this comment.
nvda/source/_magnifier/commands.py
Line 274 in 058beb5
There was a problem hiding this comment.
I intentionally avoiding changing all our internal references as the name for this feature is not stable, and will probably be changed again in future
SaschaCowley
left a comment
There was a problem hiding this comment.
@seanbudd A few changes to "avoid changing all our internal references as the name for this feature is not stable, and will probably be changed again in future".
Link to issue number:
Raised here https://groups.io/g/nvda-translations/topic/comfused_about_fullscreen/120722300
Summary of the issue:
Translators noticed some strings still refer to tracking mode as full-screen mode
Description of user facing changes:
Fix up strings to describing tracking mode as such
Description of developer facing changes:
Description of development approach:
Testing strategy:
Known issues with pull request:
we will need to another translation freeze
Code Review Checklist: