Skip to content

Fix up references to full-screen modes - #20655

Open
seanbudd wants to merge 5 commits into
betafrom
fix-tracking-mode
Open

Fix up references to full-screen modes#20655
seanbudd wants to merge 5 commits into
betafrom
fix-tracking-mode

Conversation

@seanbudd

@seanbudd seanbudd commented Aug 13, 2026

Copy link
Copy Markdown
Member

Link to issue number:

Raised here https://groups.io/g/nvda-translations/topic/comfused_about_fullscreen/120722300

Summary of the issue:

Translators noticed some strings still refer to tracking mode as full-screen mode

Description of user facing changes:

Fix up strings to describing tracking mode as such

Description of developer facing changes:

Description of development approach:

Testing strategy:

Known issues with pull request:

we will need to another translation freeze

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd added this to the 2026.2 milestone Aug 13, 2026
@seanbudd
seanbudd requested a review from a team as a code owner August 13, 2026 02:05
@seanbudd
seanbudd requested review from SaschaCowley and a lite review from Copilot August 13, 2026 02:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates NVDA Magnifier terminology so user-facing strings (and related translator guidance) refer to “tracking mode” rather than “full-screen mode”, aligning with the current feature naming and reducing confusion for translators.

Changes:

  • Updated a Magnifier settings translator comment to refer to “tracking mode”.
  • Updated the Magnifier action description string to “change tracking mode”.
  • Updated debug logging and the user announcement string to say “tracking mode”.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
source/gui/settingsDialogs.py Updates translator comment for the “Tracking mode” setting label.
source/_magnifier/utils/types.py Updates the localized action description to “change tracking mode”.
source/_magnifier/fullscreenMagnifier.py Updates debug log terminology to “tracking mode”.
source/_magnifier/commands.py Updates debug log + user announcement string and translator comment to “Tracking mode {mode}”.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread source/_magnifier/utils/types.py Outdated
Comment thread source/_magnifier/utils/types.py Outdated
Comment thread source/gui/settingsDialogs.py

@SaschaCowley SaschaCowley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get full-screen mode from config.
:return: The full-screen mode.

Set full-screen mode from settings.
:param mode: The full-screen mode to set.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"""Cycle through full-screen modes (center, border, relative)"""

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally avoiding changing all our internal references as the name for this feature is not stable, and will probably be changed again in future

Comment thread source/_magnifier/fullscreenMagnifier.py
@seanbudd
seanbudd requested a review from SaschaCowley August 14, 2026 00:37

@SaschaCowley SaschaCowley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanbudd A few changes to "avoid changing all our internal references as the name for this feature is not stable, and will probably be changed again in future".

Comment thread source/_magnifier/commands.py Outdated
Comment thread source/_magnifier/fullscreenMagnifier.py Outdated
@seanbudd
seanbudd requested a review from SaschaCowley August 14, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants