Refactor/date fns #1069
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| const ONE_MINUTE_IN_S = 60 | ||
| const ONE_HOUR_IN_S = 60 * ONE_MINUTE_IN_S | ||
| const ONE_DAY_IN_S = 24 * ONE_HOUR_IN_S | ||
| const ONE_WEEK_IN_S = 7 * ONE_DAY_IN_S | ||
| const ONE_MONTH_IN_S = 4 * ONE_WEEK_IN_S | ||
| const ONE_QUARTER_IN_S = 3 * ONE_MONTH_IN_S | ||
| const ONE_YEAR_IN_S = 12 * ONE_MONTH_IN_S | ||
|
Comment on lines
+1
to
+7
There was a problem hiding this comment. 🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- candidate files ---'
fd -t f -i 'date' . | head -80
printf '%s\n' '--- date symbols and references ---'
rg -n --glob '!node_modules' 'ONE_(MONTH|YEAR|QUARTER|WEEK|DAY|HOUR|MINUTE)_IN_S|app/lib/date|format.*date|relative' app tests . 2>/dev/null | head -240
printf '%s\n' '--- date.ts outline ---'
if command -v ast-grep >/dev/null 2>&1; then
ast-grep outline app/lib/date.ts
else
wc -l app/lib/date.ts
fi
printf '%s\n' '--- app/lib/date.ts ---'
cat -n app/lib/date.tsRepository: openSenseMap/frontend Length of output: 30854 🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- exact call sites ---'
rg -n --glob '!node_modules' 'dateDiffToNowInWords' .
printf '%s\n' '--- test/config files ---'
git ls-files | rg '(^|/)(package\.json|.*date.*spec|.*date.*test|vitest|jest|README|CHANGELOG|CONTRIBUTING)' | head -160
printf '%s\n' '--- app/lib/date.ts history summary ---'
git diff --stat -- app/lib/date.ts
git diff -- app/lib/date.ts | head -220
printf '%s\n' '--- behavioral boundary calculation ---'
node - <<'JS'
const MINUTE = 60;
const HOUR = 60 * MINUTE;
const DAY = 24 * HOUR;
const WEEK = 7 * DAY;
const MONTH = 4 * WEEK;
const QUARTER = 3 * MONTH;
const YEAR = 12 * MONTH;
function bucket(ageDays) {
const diff = Math.round(ageDays * DAY);
const abs = Math.abs(diff);
if (abs < MINUTE) return ['second', -diff];
if (abs < HOUR) return ['minute', -Math.round(diff / MINUTE)];
if (abs < DAY) return ['hour', -Math.round(diff / HOUR)];
if (abs < WEEK) return ['day', -Math.round(diff / DAY)];
if (abs < MONTH) return ['week', -Math.round(diff / WEEK)];
if (abs < QUARTER) return ['month', -Math.round(diff / MONTH)];
if (abs < YEAR) return ['quarter', -Math.round(diff / QUARTER)];
return ['year', -Math.round(diff / YEAR)];
}
for (const days of [27, 27.99, 28, 29, 56, 83, 84, 335, 336, 350, 365, 366]) {
console.log(`${days} days -> ${bucket(days)[1]} ${bucket(days)[0]}`);
}
for (const days of [350, 365, 366]) {
const d = new Date(Date.UTC(2025, 0, 1));
d.setUTCDate(d.getUTCDate() - days);
const elapsed = (Date.UTC(2025, 0, 1) - d.getTime()) / 86400000;
console.log(`calendar probe: ${days} requested -> ${d.toISOString()} -> ${elapsed} elapsed days`);
}
JSRepository: openSenseMap/frontend Length of output: 1248 Use calendar-aware differences for month and year output.
|
||
|
|
||
| export const dateDiffToNowInWords = (locale: string, date: Date) => { | ||
| const r = new Intl.RelativeTimeFormat(locale) | ||
| const now = new Date() | ||
| const diffInSeconds = Math.round((now.getTime() - date.getTime()) / 1000) | ||
| const absDiffInSeconds = Math.abs(diffInSeconds) | ||
|
|
||
| if (absDiffInSeconds < ONE_MINUTE_IN_S) | ||
| return r.format(-diffInSeconds, 'second') | ||
| if (absDiffInSeconds < ONE_HOUR_IN_S) | ||
| return r.format(-Math.round(diffInSeconds / ONE_MINUTE_IN_S), 'minute') | ||
| if (absDiffInSeconds < ONE_DAY_IN_S) | ||
| return r.format(-Math.round(diffInSeconds / ONE_HOUR_IN_S), 'hour') | ||
| if (absDiffInSeconds < ONE_WEEK_IN_S) | ||
| return r.format(-Math.round(diffInSeconds / ONE_DAY_IN_S), 'day') | ||
| if (absDiffInSeconds < ONE_MONTH_IN_S) | ||
| return r.format(-Math.round(diffInSeconds / ONE_WEEK_IN_S), 'week') | ||
| if (absDiffInSeconds < ONE_QUARTER_IN_S) | ||
| return r.format(-Math.round(diffInSeconds / ONE_MONTH_IN_S), 'month') | ||
| if (absDiffInSeconds < ONE_YEAR_IN_S) | ||
| return r.format(-Math.round(diffInSeconds / ONE_QUARTER_IN_S), 'quarter') | ||
| return r.format(-Math.round(diffInSeconds / ONE_YEAR_IN_S), 'year') | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: openSenseMap/frontend
Length of output: 4674
🏁 Script executed:
Repository: openSenseMap/frontend
Length of output: 5460
Preserve the original 20-day range offset.
addDays(January 20, 20)returns February 9. Settoto February 9 to preserve the previous default range.