Add quota editing sidemodal to system utilization page - #3330
Open
charliepark wants to merge 3 commits into
Open
Add quota editing sidemodal to system utilization page#3330charliepark wants to merge 3 commits into
charliepark wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
This doesn't have to block the PR, but it might be worth a quick experiment: what if we showed the current provisioned amount in secondary text under each input? Otherwise you have to look back at the page under the modal. Which you can do but it's weird to have to. Plus if the window is narrow enough, the modal covers the rightmost columns: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a sidemodal to the
/system/utilizationpage, allowing the operator to edit quota values from that page. Before this change, quota updates have to be done from each silo's Quotas tab. (This PR doesn't remove that functionality; just adds it to the/utilizationlist page.)Closes #2406