Update IPv6 parsing - #3334
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| function isIpv6(ip: string): boolean { | ||
| if (!ip.includes(':') || !IPV6_CHARS_REGEX.test(ip)) return false | ||
| try { | ||
| new URL(`http://[${ip}]`) |
Collaborator
There was a problem hiding this comment.
WELL THAT'S CONVENIENT
Collaborator
There was a problem hiding this comment.
Worth a comment here that the brackets are what tell it it has to be an IP and not, e.g., a domain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our parsing / validating of IPv6 addresses, to make them more compliant with
std::net::Ipv6Addrparsing. Instead of a regex, it uses thenew URL()function as part of the evaluation.Closes #1939