Honor ensure timeout during owner transitions - #19
Closed
jeregrine wants to merge 1 commit into
Closed
Conversation
Replace the fixed Group-registration subdeadline with a singleflight-coalesced retry loop that rechecks Group and durable storage until the caller's overall deadline. Return replacement owners, restart safely after released locks, and retain the last unreachable owner on timeout.
Member
|
Fixed via 690de2a . Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensure_started_child/3currently gives a live storage owner only a separate hard-coded five-second window to appear in Group. That caps callers which intentionally provide a longer:timeout, and the wait only watches the originally stored PID instead of re-evaluating an ownership handoff.This change:
{:error, {:unreachable, last_owner}}diagnostics when the overall deadline expires.The default remains effectively bounded at five seconds because the default
:timeoutis unchanged. Callers that provide a longer timeout can now use that full budget.Tests
Added deterministic coverage for:
Full suite:
Also ran
mix format --check-formattedandgit diff --check.