PHP 8.5 | UPGRADING: add missing finfo function

[jrfnl]

The entry about the new function parameter for finfo, is missing the OO method.
See: ba21ab4

[LamentXU123]

@iliaal Do we fix 8.5 UPGRADING file? This is correct.

[kamil-tekiela]

What's the point in fixing this? PHP 8.5 has shipped and I don't think we're going to use this version of UPGRADING for anything.

[LamentXU123]

That's exactly my point. Although this is technically correct I don't see the reason to fix this since 8.5 is shipped.

[iliaal]

Ditto, this already shipped, no reason to do this

[jrfnl]

If that's the policy, then why are there some 8 other updates to the PHP 8.5 UPGRADING guide which have been committed since the release ?

https://github.com/php/php-src/commits/PHP-8.5/UPGRADING

[LamentXU123]

I think mostly I or David do this when merging up. This is meaningless so we will prevent this in the future (?)
Well, given this I think we can let the 8.5 RM to decide @edorian
Perhaps I close this too soon. My apologies.

[jrfnl]

No worries @LamentXU123. If the update is not desired, that's fine. Just wanted to point out that in that case such policy should probably be applied consistently.

[kamil-tekiela]

No worries @LamentXU123. If the update is not desired, that's fine. Just wanted to point out that in that case such policy should probably be applied consistently.

I don't know if there is a policy. It's more about common sense. If the file doesn't need to be changed, then let's not bother.

[DanielEScherzer]

Looks good to me, RM approval

---

@LamentXU123 I'm not sure about adding post-GA bug fixes into UPGRADING, since it is normally assumed to document just the parts that are there since the start of the releases, but this is about something that we included pre-GA and just not documented, so all the more reason it should be added

[kamil-tekiela]

Looks good to me, RM approval

@LamentXU123 I'm not sure about adding post-GA bug fixes into UPGRADING, since it is normally assumed to document just the parts that are there since the start of the releases, but this is about something that we included pre-GA and just not documented, so all the more reason it should be added

What is file used for after GA?

[jrfnl]

What is file used for after GA?

Many companies/projects only upgrade years after a new release.... And when the migration guide may not contain sufficient detail, UPGRADING is the place to look for an explanation of changed behaviour.