Fix softwarelicense - #587
Merged
Merged
Conversation
Rom1-B
requested changes
Jun 29, 2026
stonebuzz
marked this pull request as draft
June 29, 2026 07:46
stonebuzz
force-pushed
the
fix_softwarelicense
branch
from
August 17, 2026 08:09
cd99ff8 to
b4a2276
Compare
stonebuzz
marked this pull request as ready for review
August 17, 2026 08:10
Rom1-B
requested changes
Aug 17, 2026
Rom1-B
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Fixes: !44001
The Order plugin implements a specific workflow for SoftwareLicense items:
queryRef, with thenumberfield being incremented instead of creating individual physical assets.Under these conditions, performing a bulk reception triggers the "Operation failed" error.
The issue originates in
updateReceptionStatus(). For the SoftwareLicense case processed through a bulk action,receptionAllItem()is called, but$ma->itemDone()is never executed. In contrast, theelsebranch correctly invokes$ma->itemDone(). As a result, GLPI automatically marks the item as failed, which explains the second error message displayed to the user.In addition, reception cancellation does not take into account the specific behavior of SoftwareLicense items. The current implementation applies a generic cancellation process, whereas software licenses are managed globally at the license level rather than through individual received items. Consequently, the cancellation workflow is inconsistent with the dedicated SoftwareLicense handling logic.
Screenshots (if appropriate):