Adjust SSL certificate-verification error strings for AWS-LC compat - #1751
Open
stewartsmith wants to merge 1 commit into
Open
Adjust SSL certificate-verification error strings for AWS-LC compat#1751stewartsmith wants to merge 1 commit into
stewartsmith wants to merge 1 commit into
Conversation
AWS-LC ssl.SSLCertVerificationError message differs from OpenSSL:
OpenSSL: "certificate verify failed: self signed certificate"
AWS-LC: "[SSL: CERTIFICATE_VERIFY_FAILED] CERTIFICATE_VERIFY_FAILED:\
self signed certificate (_ssl.c:1082)"
By adjusting the text being looked for to be the common substrings,
the tests work when Python is built with AWS-LC.
Member
|
Hello, I'm OK with the concept. The same change must be applied in tests/trio/test_client.py, then I can merge the PR. I assume that you are packaging websockets for AWS Linux and that you're attempting to run the tests as part of your packaging toolchain. I understand why you want to do this, but be aware that you aren't running tests properly: if you were, you would have noticed that you needed to change tests for the trio implementation. This raises questions on whether it makes sense for you to run the tests at all. Here are a few options to run a decent subset of the test suite, from shortest to most explicit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS-LC ssl.SSLCertVerificationError message differs from OpenSSL:
OpenSSL: "certificate verify failed: self signed certificate"AWS-LC: "[SSL: CERTIFICATE_VERIFY_FAILED] CERTIFICATE_VERIFY_FAILED: self signed certificate (_ssl.c:1082)"By adjusting the text being looked for to be the common substrings, the tests work when Python is built with the AWS-LC cryptographic library instead of OpenSSL.