Add sort_dicts parameter to reprlib.Repr (gh-155812) - #155817
Closed
SparshGarg999 wants to merge 2 commits into
Closed
Add sort_dicts parameter to reprlib.Repr (gh-155812)#155817SparshGarg999 wants to merge 2 commits into
SparshGarg999 wants to merge 2 commits into
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
Do not use AI to make your work without undersranding or we will ban you from our repositories. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-155812
Context & Feature Motivation
reprlib.Reprcurrently sorts dictionary keys unconditionally when generating truncated string representations (repr_dict). In applications where dictionary insertion order conveys structural or semantic meaning (such as ordered configuration dictionaries or execution AST maps), key sorting distorts the original sequence.Solution & Changes
sort_dicts: bool = Truekeyword parameter toreprlib.Repr.__init__inLib/reprlib.py(defaulting toTrueto maintain backward compatibility).repr_dictinLib/reprlib.pyto respectself.sort_dictswhen formatting dictionary keys.Testing & Verification
reprlib.Repr(sort_dicts=False)andreprlib.Repr(sort_dicts=True)formatting on dictionaries with non-alphabetical insertion orders.