[3.15] gh-155319: Fix the source line of a warning issued with module_globals (GH-155320) - #155824
Open
miss-islington wants to merge 1 commit into
Open
[3.15] gh-155319: Fix the source line of a warning issued with module_globals (GH-155320)#155824miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
…globals (pythonGH-155320) warn_explicit() computed the source line from the loader of the module whose globals were passed as module_globals, but did not pass it to WarningMessage. It also raised IndexError if lineno was out of the range of the module source. (cherry picked from commit c92e2fd8f9c8af3ea383dec6222cfcca47a405ff) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warn_explicit() computed the source line from the loader of the module
whose globals were passed as module_globals, but did not pass it to
WarningMessage. It also raised IndexError if lineno was out of the range
of the module source.
(cherry picked from commit c92e2fd)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com