_operator: Accept readable buffers in _compare_digest - #16211
Merged
JelleZijlstra merged 2 commits intoAug 15, 2026
Conversation
This comment has been minimized.
This comment has been minimized.
| @overload | ||
| def _compare_digest(a: ReadableBuffer, b: ReadableBuffer, /) -> bool: ... | ||
| @overload | ||
| def _compare_digest(a: AnyStr, b: AnyStr, /) -> bool: ... |
Member
There was a problem hiding this comment.
We can now simplify the second overload to take str instead of AnyStr, right?
Contributor
Author
There was a problem hiding this comment.
Yes — updated the second overload to use str and removed the now-unused AnyStr import in 61ec680. The targeted pre-commit, structure, Pyright, ty, pyrefly, mypy, and _operator stubtest checks all pass.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15617
Accepts arbitrary readable buffer combinations in _operator._compare_digest, matching runtime behavior and _hashlib.compare_digest.
AI assistance: Codex was used to implement and verify this change.