Skip to content

Preserve runtime allocations during constant propagation (#21897) - #21897

Open
mcremon-meta wants to merge 1 commit into
mainfrom
export-D116349009
Open

Preserve runtime allocations during constant propagation (#21897)#21897
mcremon-meta wants to merge 1 commit into
mainfrom
export-D116349009

Conversation

@mcremon-meta

@mcremon-meta mcremon-meta commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary:

Treat executorch.exir.memory.alloc as intrinsically non-constant so constant propagation never executes and lifts runtime-planned workspaces into serialized model data. This applies even when callers replace the default skip targets.

Add mirrored framework coverage for default and custom skip sets, plus a Cortex-M fused depthwise-convolution regression that verifies scratch remains a uint8 runtime allocation rather than a lifted constant.

Reviewed By: angelayi

Differential Revision: D116349009

@pytorch-bot

pytorch-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21897

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ab0a089 with merge base a1eee71 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 17, 2026
@meta-codesync

meta-codesync Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116349009.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:

Treat executorch.exir.memory.alloc as intrinsically non-constant so constant propagation never executes and lifts runtime-planned workspaces into serialized model data. This applies even when callers replace the default skip targets.

Add mirrored framework coverage for default and custom skip sets, plus a Cortex-M fused depthwise-convolution regression that verifies scratch remains a uint8 runtime allocation rather than a lifted constant.

Reviewed By: angelayi

Differential Revision: D116349009
@meta-codesync meta-codesync Bot changed the title Preserve runtime allocations during constant propagation Preserve runtime allocations during constant propagation (#21897) Aug 18, 2026
@meta-codesync
meta-codesync Bot force-pushed the export-D116349009 branch from 72d1fd5 to ab0a089 Compare August 18, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants