Bump Rust toolchain to 1.97.1

rust-toolchain.toml

@@ -1,4 +1,4 @@
 [toolchain]
-channel = "1.92.0"
+channel = "1.97.1"
 components = ["clippy", "rustfmt"]
 targets = ["x86_64-apple-darwin", "aarch64-apple-darwin", "x86_64-unknown-linux-gnu"]

src/packs.rs

@@ -65,10 +65,10 @@ pub fn create(
 ) -> anyhow::Result<()> {
     match creator::create(configuration, &name)? {
         CreateResult::AlreadyExists => {
-            println!("`{}` already exists!", &name);
+            println!("`{}` already exists!", name);
         }
         CreateResult::Success => {
-            println!("Successfully created `{}`!", &name);
+            println!("Successfully created `{}`!", name);
         }
     }
     Ok(())
@@ -246,11 +246,7 @@ pub fn lint_package_yml_files(
 pub fn delete_cache(configuration: Configuration) {
     let absolute_cache_dir = configuration.cache_directory;
     if let Err(err) = std::fs::remove_dir_all(&absolute_cache_dir) {
-        eprintln!(
-            "Failed to remove {}: {}",
-            &absolute_cache_dir.display(),
-            err
-        );
+        eprintln!("Failed to remove {}: {}", absolute_cache_dir.display(), err);
     }
 }
 

src/packs/checker.rs

@@ -167,15 +167,15 @@ impl<'a> CheckAllBuilder<'a> {
                     .map_err(|e| {
                         anyhow::Error::new(e).context(format!(
                             "Failed to strip prefix from {:?}",
-                            &self.configuration.absolute_root
+                            self.configuration.absolute_root
                         ))
                     })
                     .and_then(|path| {
                         path.to_str().ok_or_else(|| {
                             anyhow::Error::new(std::fmt::Error).context(
                                 format!(
                                     "Path ({:?}) cannot be converted to &str",
-                                    &path
+                                    path
                                 ),
                             )
                         })
@@ -314,7 +314,7 @@ pub(crate) fn update(configuration: &Configuration) -> anyhow::Result<()> {
         }
         println!(
             "{} strict mode violation(s) detected. These violations must be fixed for `check` to succeed.",
-            &strict_violations.len()
+            strict_violations.len()
         );
     }
     package_todo::write_violations_to_disk(configuration, violations);

src/packs/checker/layer.rs

@@ -53,7 +53,7 @@ impl Checker {
                 } else {
                     Some(format!(
                         "Invalid 'layer' option in '{}'. `layer` must be one of the layers defined in `packwerk.yml`",
-                        &pack.relative_yml().to_string_lossy()
+                        pack.relative_yml().to_string_lossy()
                     ))
                 }
             }

src/packs/checker/reference.rs

@@ -27,7 +27,7 @@ impl Reference {
                 .for_pack(name)
                 .context(format!(
                     "Reference#defining_pack_name is {}, but that pack is not found in pack set.",
-                    &name
+                    name
                 ))?))
         } else {
             Ok(None)
@@ -40,7 +40,7 @@ impl Reference {
     ) -> anyhow::Result<&'a Pack> {
         pack_set.for_pack(&self.referencing_pack_name).
         context(format!("Reference#referencing_pack_name is {}, but that pack is not found in pack set.", 
-        &self.referencing_pack_name))
+        self.referencing_pack_name))
     }
 }
 
@@ -59,7 +59,7 @@ impl Reference {
             Some(pack_name) => pack_name,
             None => bail!(
                 "Could not find pack for referencing file path: {}",
-                &referencing_file_path.display()
+                referencing_file_path.display()
             ),
         };
 

src/packs/creator.rs

@@ -40,11 +40,11 @@ pub fn create(
         .next_back()
         .context("unable to find pack name")?;
     std::fs::create_dir_all(new_pack_path.join("app/public/").join(pack_name))
-        .context(format!("failed to create app/public/{}", &name))?;
+        .context(format!("failed to create app/public/{}", name))?;
     std::fs::create_dir_all(
         new_pack_path.join("app/services/").join(pack_name),
     )
-    .context(format!("failed to create app/services/{}", &name))?;
+    .context(format!("failed to create app/services/{}", name))?;
     if is_rails(configuration) {
         std::fs::create_dir_all(new_pack_path.join("app/controllers/"))
             .context("failed to create app/controllers")?;

src/packs/pack.rs

@@ -428,20 +428,20 @@ pub fn write_pack_to_disk(pack: &Pack) -> anyhow::Result<()> {
     let pack_dir = pack.yml.parent().ok_or_else(|| {
         anyhow::Error::new(std::io::Error::new(
             std::io::ErrorKind::NotFound,
-            format!("Failed to get parent directory of pack {:?}", &pack.yml),
+            format!("Failed to get parent directory of pack {:?}", pack.yml),
         ))
     })?;
 
     std::fs::create_dir_all(pack_dir).map_err(|e| {
         anyhow::Error::new(e).context(format!(
             "Failed to create directory for pack {:?}",
-            &pack_dir
+            pack_dir
         ))
     })?;
 
     std::fs::write(&pack.yml, serialized_pack).map_err(|e| {
         anyhow::Error::new(e)
-            .context(format!("Failed to write pack to disk {:?}", &pack.yml))
+            .context(format!("Failed to write pack to disk {:?}", pack.yml))
     })?;
 
     Ok(())

src/packs/parsing/ruby/parse_utils.rs

@@ -148,7 +148,7 @@ pub fn get_reference_from_active_record_association(
         // Later we should probably handle these cases!
         if name.is_some() {
             let unwrapped_name = name.unwrap_or_else(|| {
-                panic!("Could not find class name for association {:?}", &node,)
+                panic!("Could not find class name for association {:?}", node)
             });
 
             Some(UnresolvedReference {

tests/common/mod.rs

@@ -13,7 +13,7 @@ pub fn teardown() {
             if let Err(err) = fs::remove_dir_all(&cache_dir) {
                 eprintln!(
                     "Failed to remove {} during test teardown: {}",
-                    &cache_dir.display(),
+                    cache_dir.display(),
                     err
                 );
             }