-
Notifications
You must be signed in to change notification settings - Fork 2
Compile inflector regexes once instead of per call #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking test-coverage note, since this table is the part where order matters most.
test_to_class_casecovers"lefe"but not"leafe", and has no case where a single input triggers two replacements in sequence (e.g. something matching both aStatu*pattern and a singular-table entry). Those cascading paths are exactly what would break if the iteration order ofCLASS_CASE_TO_SINGULARever changed — and this diff is what makes that order an explicit property of astaticrather than an incidental property of a loop.Pre-existing gap and not this PR's job to close: the refactor doesn't touch transformation logic, only where the regexes get compiled. Just a good candidate for a follow-up case or two while the reasoning is fresh.