fix(xgboost): return error instead of panicking on empty training data - #448
Open
SAY-5 wants to merge 1 commit into
Open
fix(xgboost): return error instead of panicking on empty training data#448SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #446
Checklist
Current behaviour
XGRegressor::fitpanics on a training set with zero rows.find_best_splitruns0..sorted_idxs.len() - 1, which underflows on an empty slice; in debug builds this isattempt to subtract with overflowand in release builds it surfaces asindex out of bounds. A zero-row matrix is reachable through the publicArray2::take, so this is reachable from safe user code.New expected behaviour
fitvalidates that the training data has at least one row and returnsErr(Failed::because(FailedError::ParametersError, ...))for empty data, mirroring the existingsubsamplevalidation a few lines above. A model trained on no data is not useful, so this matches the error direction the reporter preferred. Non-empty inputs are unaffected. A regression test covers the empty-data case.