feat(conflict): Init Tango-backed target-overlap conflict analyzer - #589
Open
manjari25 wants to merge 2 commits into
Open
feat(conflict): Init Tango-backed target-overlap conflict analyzer#589manjari25 wants to merge 2 commits into
manjari25 wants to merge 2 commits into
Conversation
manjari25
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
August 14, 2026 16:48
|
|
| // TargetResolver resolves the set of build targets a batch affects. The | ||
| // production implementation translates the batch's changes into a Tango | ||
| // GetChangedTargets call; tests supply a fake. | ||
| type TargetResolver interface { |
Collaborator
There was a problem hiding this comment.
should this be an internal interface?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conflict.Analyzerimplementation that detects conflicts betweenbatches based on build-target overlap, resolved through a
TargetResolverinterface whose production implementation will call Tango's
GetChangedTargetsin a follow-up PR.pathoverlap— takes identity-levelbatches, resolves targets internally, compares sets locally — but operates
at build-target granularity instead of file paths.
Test plan
make test,make lint,make fmt,make check-gazellepass