feat(sdk): add Secure Compute network selection - #275
Draft
erulkey wants to merge 2 commits into
Draft
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ute-sandboxes-reconstruction # Conflicts: # packages/vercel-sandbox/src/api-client/api-client.test.ts
Contributor
|
You must have Developer access to commit code to Vercel Labs on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
POST /v2/sandboxesnow acceptsnetworkId: string | null(explicit network, explicit opt-out) and applies a project-level Secure Compute default when the field is omitted. The SDK needs to expose that intent.What
networkId?: string | nulltoSandbox.create()params and forwards it throughAPIClient.createSandbox. Omitted means inherit the project default;nullmeans create without Secure Compute.@vercel/sandbox.Validation
nullare serialized into the request body, and that the key is absent when the option is omitted (so the API can apply the project default).