Downgrade TranslationError to warning(frontend.py) in compile_catalog - #1321
Downgrade TranslationError to warning(frontend.py) in compile_catalog#1321goodluck-ry wants to merge 2 commits into
Conversation
|
Hi!I've opened a PR to fix this: #1321 |
|
You've linked to this same PR in your comment. What is the "this" is this meant to fix? Whose wish are you referring to? The thing you flagged: isn't that pretty critical? |
Sorry for the confusion! This is my first time submitting a PR, so I messed up the links earlier. Allow me to clarify:
I will go with Option B: target only the specific "false positive" scenarios (like unmatched I'll refactor the code and update this PR shortly! |
|
Closing in favor of #1325 as this refactored version fixes the root cause in catalog.py. |
Hi! Based on your wish, I modified frontend.py to fix this: python_format false positives no longer cause the command to exit with status 1 — instead they're logged as a warning, and the command exits 0 as normal.
One thing to flag though: since this downgrades TranslationError as a whole, genuine placeholder mismatches (not just false positives) will now also exit with status 0. This means they might not get caught automatically anymore.