Skip to content

Downgrade TranslationError to warning(frontend.py) in compile_catalog #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
goodluck-ry wants to merge 2 commits into from
+7 −7
Closed

Downgrade TranslationError to warning(frontend.py) in compile_catalog #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddac666
Fix false positive python-format detection on space-flag pattern
goodluck-ry Aug 17, 2026
afc7fef
Downgrade TranslationError to warning(frontend.py) in compile_catalog
goodluck-ry Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion babel/messages/catalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def get_close_matches(word, possibilities, n=3, cutoff=0.6):
\%
(?:\(([\w]*)\))?
(
[-#0\ +]?(?:\*|[\d]+)?
[-#0+]?(?:\*|[\d]+)?
(?:\.(?:\*|[\d]+))?
[hlL]?
)
Expand Down
12 changes: 6 additions & 6 deletions babel/messages/frontend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,13 +198,13 @@ def finalize_options(self):
raise OptionError('you must specify either the output file or the base directory')

def run(self):
n_errors = 0
n_warnings = 0
for domain in self.domain:
for errors in self._run_domain(domain).values():
n_errors += len(errors)
if n_errors:
self.log.error('%d errors encountered.', n_errors)
return 1 if n_errors else 0
n_warnings += len(errors)
if n_warnings:
self.log.warning('%d warnings encountered.', n_warnings)
return 0

def _get_po_mo_triples(self, domain: str):
if not self.input_file:
Expand Down Expand Up @@ -262,7 +262,7 @@ def _run_domain(self, domain):
catalogs_and_errors[catalog] = catalog_errors = list(catalog.check())
for message, errors in catalog_errors:
for error in errors:
self.log.error('error: %s:%d: %s', po_file, message.lineno, error)
self.log.warning('warning: %s:%d: %s', po_file, message.lineno, error)

self.log.info('compiling catalog %s to %s', po_file, mo_file)

Expand Down